Skip to content

MemView: Fix coverity issues, constexpr correctness. - #1449

Merged
zwoop merged 1 commit into
apache:masterfrom
SolidWallOfCode:memview-2
Feb 15, 2017
Merged

MemView: Fix coverity issues, constexpr correctness.#1449
zwoop merged 1 commit into
apache:masterfrom
SolidWallOfCode:memview-2

Conversation

@SolidWallOfCode

@SolidWallOfCode SolidWallOfCode commented Feb 15, 2017

Copy link
Copy Markdown
Member

No description provided.

@atsci

atsci commented Feb 15, 2017

Copy link
Copy Markdown

Linux build failed! See https://ci.trafficserver.apache.org/job/linux-github/1443/ for details.

@atsci

atsci commented Feb 15, 2017

Copy link
Copy Markdown

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/freebsd-github/1549/ for details.

@atsci

atsci commented Feb 15, 2017

Copy link
Copy Markdown

clang-analyzer build successful! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/114/ for details.

@zwoop zwoop added the Core label Feb 15, 2017
@zwoop
zwoop self-requested a review February 15, 2017 16:30
@zwoop zwoop added this to the 7.2.0 milestone Feb 15, 2017
@atsci

atsci commented Feb 15, 2017

Copy link
Copy Markdown

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/freebsd-github/1550/ for details.

@atsci

atsci commented Feb 15, 2017

Copy link
Copy Markdown

Linux build successful! See https://ci.trafficserver.apache.org/job/linux-github/1444/ for details.

@atsci

atsci commented Feb 15, 2017

Copy link
Copy Markdown

clang-analyzer build successful! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/115/ for details.

@zwoop

zwoop commented Feb 15, 2017

Copy link
Copy Markdown
Contributor

One more build for good measure [approve ci].

@atsci

atsci commented Feb 15, 2017

Copy link
Copy Markdown

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/freebsd-github/1551/ for details.

@atsci

atsci commented Feb 15, 2017

Copy link
Copy Markdown

Linux build successful! See https://ci.trafficserver.apache.org/job/linux-github/1445/ for details.

@atsci

atsci commented Feb 15, 2017

Copy link
Copy Markdown

clang-analyzer build successful! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/116/ for details.

zwoop
zwoop approved these changes Feb 15, 2017
View reviewed changes

@zwoop zwoop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and fixes my issues with ICC.

@zwoop
zwoop merged commit d122179 into apache:master Feb 15, 2017
@zwoop zwoop modified the milestones: 7.2.0, 8.0.0 Apr 25, 2017
@SolidWallOfCode
SolidWallOfCode deleted the memview-2 branch May 20, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zwoop zwoop zwoop approved these changes

Assignees

@SolidWallOfCode SolidWallOfCode

Labels

Core

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@SolidWallOfCode @atsci @zwoop